Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1718723002: - Skip all html tests in dart_product mode (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Skip all html tests in dart_product mode - Skip all the tests taht deal with package root stuff in dart_product as we do not have a service isolate and it is not possible to resolve package configs. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/fe630d6a88959aab8e797d284d293898bf5b75d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M tests/html/html.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone.status View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 10 months ago (2016-02-19 22:33:03 UTC) #2
rmacnak
lgtm
4 years, 10 months ago (2016-02-19 22:57:48 UTC) #3
siva
4 years, 10 months ago (2016-02-19 23:26:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fe630d6a88959aab8e797d284d293898bf5b75d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698