Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1718633002: DM: remove unnecessary use of std::function (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: remove unnecessary use of std::function This draw_to_canvas() function doesn't need the power of std::function. This skips a copy or two, which is nice, and seems to clear up most of my MSAN problems. Why? I do not know. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718633002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot Committed: https://skia.googlesource.com/skia/+/cbf897802b41d61dc35d6db0552d8d9604945fdc

Patch Set 1 #

Patch Set 2 : optimism #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M dm/DMSrcSink.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M tools/dm_flags.json View 1 1 chunk +12 lines, -0 lines 0 comments Download
M tools/dm_flags.py View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
4 years, 10 months ago (2016-02-19 21:16:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718633002/20001
4 years, 10 months ago (2016-02-19 21:16:15 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-19 21:16:16 UTC) #7
bungeman-skia
lgtm
4 years, 10 months ago (2016-02-19 21:18:29 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 22:27:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/cbf897802b41d61dc35d6db0552d8d9604945fdc

Powered by Google App Engine
This is Rietveld 408576698