Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: pkg/analyzer/lib/src/summary/idl.dart

Issue 1718603002: Add summary support for ConstructorElement.nameEnd and .periodOffset. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/format.dart ('k') | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/idl.dart
diff --git a/pkg/analyzer/lib/src/summary/idl.dart b/pkg/analyzer/lib/src/summary/idl.dart
index ed9a3e3a842e5ef410f196e4cc3c5ec0a73eb0ac..157819487f02fda2798ffb096786084daa086ce2 100644
--- a/pkg/analyzer/lib/src/summary/idl.dart
+++ b/pkg/analyzer/lib/src/summary/idl.dart
@@ -1163,6 +1163,14 @@ abstract class UnlinkedExecutable extends base.SummaryClass {
String get name;
/**
+ * If [kind] is [UnlinkedExecutableKind.constructor] and [name] is not empty,
+ * the offset of the end of the constructor name. Otherwise zero.
+ */
+ @informative
+ @Id(23)
+ int get nameEnd;
+
+ /**
* Offset of the executable name relative to the beginning of the file. For
* named constructors, this excludes the class name and excludes the ".".
* For unnamed constructors, this is the offset of the class name (i.e. the
@@ -1181,6 +1189,14 @@ abstract class UnlinkedExecutable extends base.SummaryClass {
List<UnlinkedParam> get parameters;
/**
+ * If [kind] is [UnlinkedExecutableKind.constructor] and [name] is not empty,
+ * the offset of the period before the constructor name. Otherwise zero.
+ */
+ @informative
+ @Id(24)
+ int get periodOffset;
+
+ /**
* If [isRedirectedConstructor] and [isFactory] are both `true`, the
* constructor to which this constructor redirects; otherwise empty.
*/
@@ -1429,6 +1445,14 @@ abstract class UnlinkedParam extends base.SummaryClass {
UnlinkedConst get defaultValue;
/**
+ * If the parameter has a default value, the source text of the constant
+ * expression in the default value. Otherwise the empty string.
+ */
+ @informative
+ @Id(13)
+ String get defaultValueCode;
+
+ /**
* If this parameter's type is inferable, nonzero slot id identifying which
* entry in [LinkedLibrary.types] contains the inferred type. If there is no
* matching entry in [LinkedLibrary.types], then no type was inferred for
@@ -1482,14 +1506,6 @@ abstract class UnlinkedParam extends base.SummaryClass {
int get nameOffset;
/**
- * If the parameter has a default value, the source text of the constant
- * expression in the default value. Otherwise the empty string.
- */
- @informative
- @Id(13)
- String get defaultValueCode;
-
- /**
* If [isFunctionTyped] is `true`, the parameters of the function type.
*/
@Id(8)
« no previous file with comments | « pkg/analyzer/lib/src/summary/format.dart ('k') | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698