Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

Issue 1718563002: Convert location bar decorations to Material Design (Mac). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@md_toolbar
Patch Set: Fix issue from browser test. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm b/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
index 08d012fbc9e54258a6cda5a725594c17d3fe3cf1..9222a30dd3976c87d9e01ffa55ccedad0faeaf14 100644
--- a/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
+++ b/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
@@ -16,6 +16,11 @@
#include "grit/theme_resources.h"
#include "ui/base/cocoa/cocoa_base_utils.h"
#include "ui/base/l10n/l10n_util_mac.h"
+#include "ui/base/material_design/material_design_controller.h"
+#include "ui/gfx/color_palette.h"
+#include "ui/gfx/image/image_skia_util_mac.h"
+#include "ui/gfx/paint_vector_icon.h"
+#include "ui/gfx/vector_icons_public.h"
ZoomDecoration::ZoomDecoration(LocationBarViewMac* owner)
: owner_(owner),
@@ -28,7 +33,9 @@ ZoomDecoration::~ZoomDecoration() {
}
bool ZoomDecoration::UpdateIfNecessary(
- ui_zoom::ZoomController* zoom_controller, bool default_zoom_changed) {
+ ui_zoom::ZoomController* zoom_controller,
+ bool default_zoom_changed,
+ bool location_bar_is_dark) {
if (!ShouldShowDecoration()) {
if (!IsVisible() && !bubble_)
return false;
@@ -47,7 +54,7 @@ bool ZoomDecoration::UpdateIfNecessary(
return false;
}
- ShowAndUpdateUI(zoom_controller, zoom_string);
+ ShowAndUpdateUI(zoom_controller, zoom_string, location_bar_is_dark);
return true;
}
@@ -88,16 +95,35 @@ void ZoomDecoration::HideUI() {
}
void ZoomDecoration::ShowAndUpdateUI(ui_zoom::ZoomController* zoom_controller,
- NSString* tooltip_string) {
- int image_id = IDR_ZOOM_NORMAL;
- ui_zoom::ZoomController::RelativeZoom relative_zoom =
- zoom_controller->GetZoomRelativeToDefault();
- if (relative_zoom == ui_zoom::ZoomController::ZOOM_BELOW_DEFAULT_ZOOM)
- image_id = IDR_ZOOM_MINUS;
- else if (relative_zoom == ui_zoom::ZoomController::ZOOM_ABOVE_DEFAULT_ZOOM)
- image_id = IDR_ZOOM_PLUS;
-
- SetImage(OmniboxViewMac::ImageForResource(image_id));
+ NSString* tooltip_string,
+ bool location_bar_is_dark) {
+ if (ui::MaterialDesignController::IsModeMaterial()) {
+ ui_zoom::ZoomController::RelativeZoom relative_zoom =
+ zoom_controller->GetZoomRelativeToDefault();
+ // There is no ZOOM_NORMAL under Material Design.
+ gfx::VectorIconId iconId =
+ relative_zoom == ui_zoom::ZoomController::ZOOM_BELOW_DEFAULT_ZOOM
+ ? gfx::VectorIconId::ZOOM_MINUS
+ : gfx::VectorIconId::ZOOM_PLUS;
+
+ SkColor vectorIconColor = location_bar_is_dark ? SK_ColorWHITE
+ : gfx::kChromeIconGrey;
+ NSImage* theImage =
+ NSImageFromImageSkia(gfx::CreateVectorIcon(iconId,
+ 16,
+ vectorIconColor));
+ SetImage(theImage);
+ } else {
+ int image_id = IDR_ZOOM_NORMAL;
+ ui_zoom::ZoomController::RelativeZoom relative_zoom =
+ zoom_controller->GetZoomRelativeToDefault();
+ if (relative_zoom == ui_zoom::ZoomController::ZOOM_BELOW_DEFAULT_ZOOM)
+ image_id = IDR_ZOOM_MINUS;
+ else if (relative_zoom == ui_zoom::ZoomController::ZOOM_ABOVE_DEFAULT_ZOOM)
+ image_id = IDR_ZOOM_PLUS;
+
+ SetImage(OmniboxViewMac::ImageForResource(image_id));
+ }
tooltip_.reset([tooltip_string retain]);

Powered by Google App Engine
This is Rietveld 408576698