chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm - Issue 1718563002: Convert location bar decorations to Material Design (Mac).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Issue 1718563002: Convert location bar decorations to Material Design (Mac). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@md_toolbar

Patch Set: Ready for review. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm ('K') | « chrome/browser/ui/cocoa/toolbar/toolbar_controller.h ('k') | components/omnibox/browser/autocomplete_match.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

index 520de8ea41a66768f1d86cb469bdb97a19b1c18c..1412b3ca8a392a4a5ca2b497c6a2b3266187bcfc 100644

--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

@@ -609,6 +609,12 @@ class NotificationBridge : public AppMenuBadgeController::Delegate {

return locationBarView_.get();

}

+- (void)locationBarWasAddedToWindow {

+ // ALlow the |locationBarView_| to update itself to match the browser window

Avi (use Gerrit) 2016/03/15 16:03:06 s/ALlow/Allow/

shrike 2016/03/15 17:54:56 Thanks.

+ // theme.

+ locationBarView_->OnAddedToWindow();

- (void)focusLocationBar:(BOOL)selectAll {

if (locationBarView_.get()) {

locationBarView_->FocusLocation(selectAll ? true : false);