Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 1718543003: Restore natural enum type for EventSource::State (Closed)

Created:
4 years, 10 months ago by brucedawson
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-events_chromium.org, chromium-reviews, danakj, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore natural enum type for EventSource::State Due to some implicit constructors tracked by crbug.com/581254 the type of EventSource::State was set to unsigned short instead of short. Now that 581254 has been addressed this type can be changed back. BUG=581254 Committed: https://crrev.com/dc9e631a74a208e0d70a550ef77cdddedcb99550 Cr-Commit-Position: refs/heads/master@{#376637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/page/EventSource.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
brucedawson
Now that the implicit constructors have been addressed we can set this type back to ...
4 years, 10 months ago (2016-02-20 00:42:04 UTC) #2
leviw_travelin_and_unemployed
#stolenfrompdr LGTM :)
4 years, 10 months ago (2016-02-20 00:48:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718543003/1
4 years, 10 months ago (2016-02-20 01:17:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/176813)
4 years, 10 months ago (2016-02-20 02:32:23 UTC) #8
brucedawson
On 2016/02/20 02:32:23, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 10 months ago (2016-02-20 04:46:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718543003/1
4 years, 10 months ago (2016-02-20 04:48:15 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-20 07:09:34 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-20 07:10:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc9e631a74a208e0d70a550ef77cdddedcb99550
Cr-Commit-Position: refs/heads/master@{#376637}

Powered by Google App Engine
This is Rietveld 408576698