Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1718503002: Add use-counter to MediaStream onended event handler. (Closed)

Created:
4 years, 10 months ago by Guido Urdaneta
Modified:
4 years, 10 months ago
CC:
blink-reviews, chromium-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use-counter to MediaStream onended event handler. This is the first step towards deprecation and removal. BUG=586924 Committed: https://crrev.com/54a225210f59a070eb75def3e3d9d21f2e323a47 Cr-Commit-Position: refs/heads/master@{#376540}

Patch Set 1 #

Patch Set 2 : Add UseCounter and histogram entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Guido Urdaneta
Hi, jochen@chromium.org: please review third_party/Webkit isherman@chromium.org: please review histogram.xml
4 years, 10 months ago (2016-02-19 12:27:54 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-19 14:47:19 UTC) #3
Ilya Sherman
histograms.xml lgtm
4 years, 10 months ago (2016-02-19 17:14:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718503002/20001
4 years, 10 months ago (2016-02-19 20:11:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-19 21:37:07 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 21:38:55 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54a225210f59a070eb75def3e3d9d21f2e323a47
Cr-Commit-Position: refs/heads/master@{#376540}

Powered by Google App Engine
This is Rietveld 408576698