Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1718483002: Revert of [turbofan] Connect ObjectIsNumber to effect and control chains. (Closed)

Created:
4 years, 10 months ago by Jarin
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@move-change-low
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Connect ObjectIsNumber to effect and control chains. (patchset #1 id:1 of https://codereview.chromium.org/1709093002/ ) Reason for revert: Tanks benchmarks (e.g., Octane box2d TF). Original issue's description: > [turbofan] Connect ObjectIsNumber to effect and control chains. > > In theory, we could connect the nodes when doing > the schedule-in-the-middle pass, but that would require creating two > versions of the operator (effectful and pure). I believe we do not > lose anything by wiring the node up eagerly. > > Committed: https://crrev.com/2894e80a0a4a51a0d72e72aa48fcd01968f7949f > Cr-Commit-Position: refs/heads/master@{#34141} TBR=bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2ae5894da649614214a56d5cc5856f2faf01acd3 Cr-Commit-Position: refs/heads/master@{#34147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -69 lines) Patch
M src/compiler/change-lowering.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/compiler/change-lowering.cc View 2 chunks +17 lines, -25 lines 0 comments Download
M src/compiler/graph-reducer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 4 chunks +1 line, -16 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jarin
Created Revert of [turbofan] Connect ObjectIsNumber to effect and control chains.
4 years, 10 months ago (2016-02-19 10:13:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718483002/1
4 years, 10 months ago (2016-02-19 10:13:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 10:13:42 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 10:14:02 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ae5894da649614214a56d5cc5856f2faf01acd3
Cr-Commit-Position: refs/heads/master@{#34147}

Powered by Google App Engine
This is Rietveld 408576698