third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-use.html - Issue 1718463002: Gracefully handle nested eventSender.beginDragWithFiles() attempts.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-use.html

Issue 1718463002: Gracefully handle nested eventSender.beginDragWithFiles() attempts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/test_runner/event_sender.cc ('k') | third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-use-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../../resources/js-test.js"></script>

	5 <script>

	6 description("Test that unsupported nested use of eventSender.beginDragWithFiles( ) is handled without crashing.");

	7

	8 window.jsTestIsAsync = true;
	dcheng 2016/02/19 18:16:27 Does the test need to be async? Does the test need to be async? sof 2016/02/19 18:37:48 Most tests in this directory are keyed off onload, Show quoted text On 2016/02/19 18:16:27, dcheng wrote: > Does the test need to be async? Most tests in this directory are keyed off onload, so I assume drag testing was. I can try to change..does it matter much? dcheng 2016/02/19 18:39:21 If the test runs synchronously in onload, making i Show quoted text On 2016/02/19 at 18:37:48, sof wrote: > On 2016/02/19 18:16:27, dcheng wrote: > > Does the test need to be async? > > Most tests in this directory are keyed off onload, so I assume drag testing was. I can try to change..does it matter much? If the test runs synchronously in onload, making it async shouldn't be necessary. It's not strictly required, but it's nice to have a slightly simpler test. sof 2016/02/19 20:03:17 De-async'ified the test; works fine. Show quoted text On 2016/02/19 18:39:21, dcheng wrote: > On 2016/02/19 at 18:37:48, sof wrote: > > On 2016/02/19 18:16:27, dcheng wrote: > > > Does the test need to be async? > > > > Most tests in this directory are keyed off onload, so I assume drag testing > was. I can try to change..does it matter much? > > If the test runs synchronously in onload, making it async shouldn't be > necessary. > > It's not strictly required, but it's nice to have a slightly simpler test. De-async'ified the test; works fine.
	9

	10 if (window.testRunner) {

	11 testRunner.dumpAsText();

	12 testRunner.waitUntilDone();

	13 }

	14

	15 function runTest()

	16 {

	17 eventSender.beginDragWithFiles(["resources/empty.html"]);

	18 eventSender.beginDragWithFiles(["resources/empty.html"]);

	19 eventSender.mouseMoveTo(10, 10);

	20 eventSender.mouseUp();

	21 }

	22 window.onload = function () {

	23 shouldThrow("runTest()");

	24 finishJSTest();

	25 };

	26 </script>

	27 </body>

	28 </html>

OLD	NEW