Add a proper bounds check to XFA_FM_KeywordToString

Add a proper bounds check to XFA_FM_KeywordToString

R=tsepez@chromium.org
BUG=588200
Committed: https://pdfium.googlesource.com/pdfium/+/f348235cce75d378a17f3aee81a97f92049fa0a8

[Oliver Chang, 2016-02-19 23:00:36]

ptal, trivial patch

[Tom Sepez, 2016-02-19 23:09:45]

https://codereview.chromium.org/1718453003/diff/1/xfa/src/fxfa/src/fm2js/xfa_...
File xfa/src/fxfa/src/fm2js/xfa_lexer.cpp (right):

https://codereview.chromium.org/1718453003/diff/1/xfa/src/fxfa/src/fm2js/xfa_...
xfa/src/fxfa/src/fm2js/xfa_lexer.cpp:154: if (op < KEYWORD_START || op >
KEYWORD_END)
TOKdo isn't the first enum value, are you sure you don't want this to return the
ones before it?

[Oliver Chang, 2016-02-19 23:12:58]

https://codereview.chromium.org/1718453003/diff/1/xfa/src/fxfa/src/fm2js/xfa_...
File xfa/src/fxfa/src/fm2js/xfa_lexer.cpp (right):

https://codereview.chromium.org/1718453003/diff/1/xfa/src/fxfa/src/fm2js/xfa_...
xfa/src/fxfa/src/fm2js/xfa_lexer.cpp:154: if (op < KEYWORD_START || op >
KEYWORD_END)
On 2016/02/19 23:09:45, Tom Sepez wrote:
> TOKdo isn't the first enum value, are you sure you don't want this to return
the
> ones before it?

I assume this is the intention of this function, since the other enum values
appear to be syntax constructs like "(" rather than being a "keyword". TOKendif
isn't the last enum value either.

[Tom Sepez, 2016-02-19 23:17:51]

OK, LGTM, since we're looking at a range withing the enum, we don't have to
worry about the optimizer removing the check (as we would if it were
comparisions with the first/last values).

https://codereview.chromium.org/1718453003/diff/1/xfa/src/fxfa/src/fm2js/xfa_...
File xfa/src/fxfa/src/fm2js/xfa_lexer.cpp (right):

https://codereview.chromium.org/1718453003/diff/1/xfa/src/fxfa/src/fm2js/xfa_...
xfa/src/fxfa/src/fm2js/xfa_lexer.cpp:154: if (op < KEYWORD_START || op >
KEYWORD_END)
On 2016/02/19 23:12:57, Oliver Chang wrote:
> On 2016/02/19 23:09:45, Tom Sepez wrote:
> > TOKdo isn't the first enum value, are you sure you don't want this to return
> the
> > ones before it?
> 
> I assume this is the intention of this function, since the other enum values
> appear to be syntax constructs like "(" rather than being a "keyword".
TOKendif
> isn't the last enum value either.

Acknowledged.

[Oliver Chang, 2016-02-19 23:23:33]

Description was changed from

==========
Add a proper bounds check to XFA_FM_KeywordToString

R=tsepez@chromium.org
BUG=588200
==========

to

==========
Add a proper bounds check to XFA_FM_KeywordToString

R=tsepez@chromium.org
BUG=588200

Committed:
https://pdfium.googlesource.com/pdfium/+/f348235cce75d378a17f3aee81a97f92049f...
==========

[Oliver Chang, 2016-02-19 23:23:34]

Committed patchset #1 (id:1) manually as
f348235cce75d378a17f3aee81a97f92049fa0a8 (presubmit successful).