Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2261)

Unified Diff: chrome/browser/ui/webui/chromeos/drive_internals_ui.cc

Issue 171843003: Remove --disable-drive flag and flags section in drive-internals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/drive_internals.js ('k') | chromeos/chromeos_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
diff --git a/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc b/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
index 5d4de45cd2b916478141ed6d62f49fc9038c38ce..eec636c95fbb5b0dcda1fc6f148f9db8a2a9c540 100644
--- a/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
@@ -25,12 +25,10 @@
#include "chrome/browser/drive/drive_notification_manager.h"
#include "chrome/browser/drive/drive_notification_manager_factory.h"
#include "chrome/browser/drive/drive_service_interface.h"
-#include "chrome/browser/drive/drive_switches.h"
#include "chrome/browser/drive/event_logger.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
-#include "chromeos/chromeos_switches.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/web_ui.h"
#include "content/public/browser/web_ui_data_source.h"
@@ -234,7 +232,6 @@ class DriveInternalsWebUIHandler : public content::WebUIMessageHandler {
void OnPageLoaded(const base::ListValue* args);
// Updates respective sections.
- void UpdateDriveRelatedFlagsSection();
void UpdateDriveRelatedPreferencesSection();
void UpdateConnectionStatusSection(
drive::DriveServiceInterface* drive_service);
@@ -437,7 +434,6 @@ void DriveInternalsWebUIHandler::OnPageLoaded(const base::ListValue* args) {
integration_service->debug_info_collector();
DCHECK(debug_info_collector);
- UpdateDriveRelatedFlagsSection();
UpdateDriveRelatedPreferencesSection();
UpdateConnectionStatusSection(drive_service);
UpdateAboutResourceSection(drive_service);
@@ -458,26 +454,6 @@ void DriveInternalsWebUIHandler::OnPageLoaded(const base::ListValue* args) {
UpdateEventLogSection();
}
-void DriveInternalsWebUIHandler::UpdateDriveRelatedFlagsSection() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-
- const char* kDriveRelatedFlags[] = {
- drive::switches::kEnableDriveV2Api,
- chromeos::switches::kDisableDrive,
- };
-
- base::ListValue flags;
- for (size_t i = 0; i < arraysize(kDriveRelatedFlags); ++i) {
- const std::string key = kDriveRelatedFlags[i];
- std::string value = "(not set)";
- if (CommandLine::ForCurrentProcess()->HasSwitch(key))
- value = CommandLine::ForCurrentProcess()->GetSwitchValueASCII(key);
- AppendKeyValue(&flags, key, value.empty() ? "(set)" : value);
- }
-
- web_ui()->CallJavascriptFunction("updateDriveRelatedFlags", flags);
-}
-
void DriveInternalsWebUIHandler::UpdateDriveRelatedPreferencesSection() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
« no previous file with comments | « chrome/browser/resources/chromeos/drive_internals.js ('k') | chromeos/chromeos_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698