Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 171843003: Remove --disable-drive flag and flags section in drive-internals. (Closed)

Created:
6 years, 10 months ago by kinaba
Modified:
6 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Remove --disable-drive flag and flags section in drive-internals. This is a part of the flag clean up effort. Since --disable-drive flag is now a user configurable (by chrome:settings) preference, we don't need a flag. BUG=344738 TBR=mnissler@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M chrome/browser/prefs/command_line_pref_store.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/drive_internals.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/drive_internals.js View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 4 chunks +0 lines, -24 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
kinaba
6 years, 10 months ago (2014-02-19 03:12:58 UTC) #1
hashimoto
lgtm
6 years, 10 months ago (2014-02-19 04:28:31 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-19 04:30:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/171843003/1
6 years, 10 months ago (2014-02-19 04:30:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 04:35:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-19 04:35:49 UTC) #6
kinaba
TBR'ing mnissler@ for c/b/prefs for the removal.
6 years, 10 months ago (2014-02-19 05:03:10 UTC) #7
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-19 05:03:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/171843003/1
6 years, 10 months ago (2014-02-19 05:03:33 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 05:04:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel
6 years, 10 months ago (2014-02-19 05:04:02 UTC) #11
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-19 05:30:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/171843003/1
6 years, 10 months ago (2014-02-19 05:30:21 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 05:30:57 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel
6 years, 10 months ago (2014-02-19 05:30:57 UTC) #15
Mattias Nissler (ping if slow)
LGTM
6 years, 10 months ago (2014-02-19 08:09:36 UTC) #16
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-19 08:10:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/171843003/1
6 years, 10 months ago (2014-02-19 08:10:54 UTC) #18
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 08:31:06 UTC) #19
Message was sent while issue was closed. 
Change committed as 252004

Powered by Google App Engine
This is Rietveld 408576698