Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1718423002: Simplify and combine SkDrawCacheProc and SkMeasureCacheProc to SkPaint::GlyphCacheProc. (Closed)

Created:
4 years, 10 months ago by dogben
Modified:
4 years, 10 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify and combine SkDrawCacheProc and SkMeasureCacheProc to SkPaint::GlyphCacheProc. All callers of (the result of) SkPaint::getDrawCacheProc were passing zero as the last two arguments. This is the same as (the result of) SkPaint::getMeasureCacheProc(true). Per bungeman, make this typedef a member of SkPaint. Although the typedef is technically public, the only uses are private, so this is not really an API change. TBR=reed GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718423002 Committed: https://skia.googlesource.com/skia/+/d936f63c35fb7dfb2b6c20802206adbfc3cc48d0

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -141 lines) Patch
M include/core/SkPaint.h View 3 chunks +3 lines, -7 lines 0 comments Download
M src/core/SkDraw.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkPaint.cpp View 6 chunks +8 lines, -112 lines 0 comments Download
M src/core/SkTextToPathIter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 1 7 chunks +9 lines, -9 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718423002/1
4 years, 10 months ago (2016-02-23 00:45:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 00:57:49 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718423002/20001
4 years, 10 months ago (2016-02-23 16:37:00 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 16:55:41 UTC) #11
dogben
4 years, 10 months ago (2016-02-23 17:36:36 UTC) #13
bungeman-skia
lgtm
4 years, 10 months ago (2016-02-23 18:23:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718423002/20001
4 years, 10 months ago (2016-02-23 18:43:50 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 18:44:35 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d936f63c35fb7dfb2b6c20802206adbfc3cc48d0

Powered by Google App Engine
This is Rietveld 408576698