third_party/WebKit/Source/bindings/core/v8/ScriptController.h - Issue 1718403002: Fix security checks when navigating remote frames to javascript: URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptController.h

Issue 1718403002: Fix security checks when navigating remote frames to javascript: URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass v8::Isolate directly Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.h b/third_party/WebKit/Source/bindings/core/v8/ScriptController.h

index 78a6ca909ccdbee9eaaef65a84c88c5db164c71e..09f290d6f10bfba3202cd76721eec4305a3ef5b1 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.h

@@ -123,7 +123,7 @@ public:

void enableEval();

void disableEval(const String& errorMessage);

- static bool canAccessFromCurrentOrigin(LocalFrame*);

+ static bool canAccessFromCurrentOrigin(v8::Isolate*, Frame*);

static void setCaptureCallStackForUncaughtExceptions(v8::Isolate*, bool);

void collectIsolatedContexts(Vector<std::pair<ScriptState*, SecurityOrigin*>>&);

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp » ('j') | no next file with comments »