Issue 1718353002: Fixes #460

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1718353002: Fixes #460 (Closed)

Created:
4 years, 10 months ago by vsm

Modified:
4 years, 10 months ago

Reviewers:
Jacob, Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org, devoncarew

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -6 lines)			Patch
M	lib/runtime/dart/js.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tool/input_sdk/lib/js/dart2js/js_dart2js.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tool/sdk_expected_errors.txt	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

vsm

Committed patchset #1 (id:1) manually as 6783b4bc8c59e3f1e72d39b6e09bacfde3e56fbe (presubmit successful).

4 years, 10 months ago (2016-02-22 23:04:05 UTC) #5

Message was sent while issue was closed.

lgtm