Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1718343002: Remove unnecessary GOOGLE3 ifdefs from SkRawCodec (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unnecessary GOOGLE3 ifdefs from SkRawCodec These should be fine now that SkJpegCodec is building in GOOGLE3. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718343002 Committed: https://skia.googlesource.com/skia/+/9ca27f39ddf7dafdc8ce97dba0fc9c4d1f07b7ed

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/codec/SkRawCodec.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
msarett
4 years, 10 months ago (2016-02-22 22:19:56 UTC) #4
dogben
On 2016/02/22 at 22:19:56, msarett wrote: > I wrote some instructions on how to test ...
4 years, 10 months ago (2016-02-22 22:56:18 UTC) #5
dogben
lgtm LGTM if presubmit passes.
4 years, 10 months ago (2016-02-22 22:57:43 UTC) #6
msarett
Presubmit passes! Instructions were great!
4 years, 10 months ago (2016-02-23 16:08:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718343002/20001
4 years, 10 months ago (2016-02-23 16:09:33 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 16:21:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9ca27f39ddf7dafdc8ce97dba0fc9c4d1f07b7ed

Powered by Google App Engine
This is Rietveld 408576698