Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/dm_flags.py

Issue 1718273004: Add an SkImageGeneratorCG (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Blacklist questionable bmps on CG Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index a790184968444d53b97be7f8fbf4530df7f5ca1b..35ea8d02e3df4592eec91e08ecf5af30b91b0463 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -113,6 +113,23 @@ def get_args(bot):
blacklist.extend('_ image _ interlaced2.png'.split(' '))
blacklist.extend('_ image _ interlaced3.png'.split(' '))
+ # CG fails on questionable bmps
+ if 'Mac' in bot or 'iOS' in bot:
+ blacklist.extend('_ image gen_platform_opaque rgba32abf.bmp'.split(' '))
scroggo 2016/03/09 19:44:01 Doesn't the blacklist check for partial matches? e
msarett 2016/03/09 20:55:44 Done.
+ blacklist.extend('_ image gen_platform_premul rgba32abf.bmp'.split(' '))
+ blacklist.extend('_ image gen_platform_opaque rgb24prof.bmp'.split(' '))
+ blacklist.extend('_ image gen_platform_premul rgb24prof.bmp'.split(' '))
+ blacklist.extend('_ image gen_platform_opaque rgb24lprof.bmp'.split(' '))
+ blacklist.extend('_ image gen_platform_premul rgb24lprof.bmp'.split(' '))
+ blacklist.extend('_ image gen_platform_opaque 8bpp-pixeldata-cropped.bmp'.split(' '))
+ blacklist.extend('_ image gen_platform_premul 8bpp-pixeldata-cropped.bmp'.split(' '))
+ blacklist.extend('_ image gen_platform_opaque 4bpp-pixeldata-cropped.bmp'.split(' '))
+ blacklist.extend('_ image gen_platform_premul 4bpp-pixeldata-cropped.bmp'.split(' '))
+ blacklist.extend('_ image gen_platform_opaque 32bpp-pixeldata-cropped.bmp'.split(' '))
+ blacklist.extend('_ image gen_platform_premul 32bpp-pixeldata-cropped.bmp'.split(' '))
+ blacklist.extend('_ image gen_platform_opaque 24bpp-pixeldata-cropped.bmp'.split(' '))
+ blacklist.extend('_ image gen_platform_premul 24bpp-pixeldata-cropped.bmp'.split(' '))
+
# skia:4095
for test in ['not_native32_bitmap_config',
'bleed_image',
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698