Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: extensions/common/api/PRESUBMIT.py

Issue 1718243003: [Extern Generation] Add a presubmit script to check externs not being updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/PRESUBMIT.py
diff --git a/extensions/common/api/PRESUBMIT.py b/extensions/common/api/PRESUBMIT.py
new file mode 100644
index 0000000000000000000000000000000000000000..2d4e55edaf13732989b7d4494140780265a62aac
--- /dev/null
+++ b/extensions/common/api/PRESUBMIT.py
@@ -0,0 +1,30 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Chromium presubmit script for src/extensions/common.
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
+for more details on the presubmit API built into depot_tools.
+"""
+
+import sys
+
+_API_PAIRS = {
+ 'extensions/common/api/bluetooth.idl': 'ui/externs/bluetooth.js',
Devlin 2016/02/22 23:26:14 Just adding one for now. Step 2: add all the ones
Dan Beam 2016/02/23 03:15:23 nit: use os.path.join() maybe?
Devlin 2016/02/23 23:12:39 Good call, done.
+ #TODO(devlin): Add more!
+}
+
+def _CheckExterns(input_api, output_api):
+ original_sys_path = sys.path
+
+ try:
+ sys.path.append(input_api.PresubmitLocalPath())
+ from externs_checker import ExternsChecker
+ finally:
+ sys.path = original_sys_path
+
+ return ExternsChecker(input_api, output_api, _API_PAIRS).RunChecks()
+
+def CheckChangeOnUpload(input_api, output_api):
+ return _CheckExterns(input_api, output_api)

Powered by Google App Engine
This is Rietveld 408576698