LayoutTests/http/tests/webfont/slow-loading.html - Issue 171823002: Make text visible when font loading takes longer than 3 seconds

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/webfont/slow-loading.html

Issue 171823002: Make text visible when font loading takes longer than 3 seconds (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/http/tests/webfont/slow-ahem-loading.cgi ('k') | LayoutTests/http/tests/webfont/slow-loading-expected.html » ('j') | Source/core/css/CSSCustomFontData.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <style>

	4 @font-face {

	5 font-family:ahem-4sec;

	6 src: url(slow-ahem-loading.cgi?delay=4000);

	7 }

	8 @font-face {

	9 font-family:ahem-8sec;

	10 src: url(slow-ahem-loading.cgi?delay=8000);

	11 }

	12 @font-face {

	13 font-family:ahem-5sec;

	14 src: url(slow-ahem-loading.cgi?delay=5000);

	15 }

	16 .testspan {

	17 font-size:64px;

	18 border: 1px solid;

	19 }

	20 #span1 {

	21 font-family: ahem-4sec, Arial;

	22 }

	23 #span2 {

	24 font-family: ahem-8sec, Arial;

	25 }

	26 #span3 {

	27 font-family: ahem-5sec, Arial;

	28 }

	29 </style>

	30 </head>

	31 <body>

	32

	33 Ahem after 5 seconds:

	34 <br/>

	35 <span class="testspan" id="span1" style="display: none;">

	36 abcdefg

	37 </span>

	38 <br/>

	39

	40 Arial after 5 seconds:

	41 <br/>

	42 <span class="testspan" id="span2" style="display: none;">

	43 abcdefg

	44 </span>

	45 <br/>

	46

	47 Blank after 5 seconds:

	48 <br/>

	49 <span class="testspan" id="span3" style="display: none;">

	50 abcdefg

	51 </span>

	52 <br/>

	53

	54 <script>

	55

	56 if (window.testRunner)

	57 testRunner.waitUntilDone();

	58

	59 function displayElementAfter(id, msec) {

	60 setTimeout(function() {

	61 document.getElementById(id).style.removeProperty("display");

	62 }, msec);

	63 }

	64

	65 window.onload = function() {

	66 displayElementAfter("span1", 0);

	67 displayElementAfter("span2", 0);
	eae 2014/02/20 16:51:47 What is the purpose of the msec argument here and What is the purpose of the msec argument here and why is it different for the three spans? Kunihiko Sakamoto 2014/02/21 03:38:24 For span3, we want to start the loading at T=3(sec Show quoted text On 2014/02/20 16:51:47, eae wrote: > What is the purpose of the msec argument here and why is it different for the > three spans? For span3, we want to start the loading at T=3(sec) so the load does not exceed the wait limit at the point of test completion (T=5). The zero timeouts for span1 and span2 are subtle: we need to start loading them after onload(), otherwise TestRunner waits for these loads to complete.
	68 displayElementAfter("span3", 3000);

	69 setTimeout(function() { if (window.testRunner) testRunner.notifyDone(); }, 5 000);

	70 };

	71

	72 </script>

	73 </body>

	74 </html>

OLD	NEW