Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1718213003: [DevTools] Add "show throttling" to device mode instead of "configure network". (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Add "show throttling" to device mode instead of "configure network". This shows network throttling select in place, similarly to other controls. BUG=582815 Committed: https://crrev.com/e8bf430aaddf1407766ea7afb6ee4eef128d1987 Cr-Commit-Position: refs/heads/master@{#377404}

Patch Set 1 #

Messages

Total messages: 9 (3 generated)
dgozman
Take a look please. Screenshot: http://pasteboard.co/1KNAjdfx.png
4 years, 10 months ago (2016-02-22 22:25:56 UTC) #2
pbakaus
On 2016/02/22 at 22:25:56, dgozman wrote: > Take a look please. Screenshot: http://pasteboard.co/1KNAjdfx.png Very nice!
4 years, 10 months ago (2016-02-23 23:31:29 UTC) #3
pfeldman
lgtm
4 years, 10 months ago (2016-02-24 19:59:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718213003/1
4 years, 10 months ago (2016-02-24 20:07:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 22:15:27 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 22:18:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8bf430aaddf1407766ea7afb6ee4eef128d1987
Cr-Commit-Position: refs/heads/master@{#377404}

Powered by Google App Engine
This is Rietveld 408576698