Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 171813015: Don't disable hash randomization option in predictable mode. (Closed)

Created:
6 years, 10 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Don't disable hash randomization option in predictable mode. We don't need it because 1) hash randomization uses random generator whose results depend on --random-seed option which is set in predictable mode. 2) disabling hash randomization triggers assert in snapshot mode. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19647

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review notes applied #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.cc View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Igor Sheludko
PTAL
6 years, 10 months ago (2014-02-20 17:24:13 UTC) #1
Sven Panne
LGTM with a nit. https://codereview.chromium.org/171813015/diff/1/src/v8.cc File src/v8.cc (right): https://codereview.chromium.org/171813015/diff/1/src/v8.cc#newcode189 src/v8.cc:189: if (FLAG_random_seed == 0) { ...
6 years, 10 months ago (2014-02-24 10:10:01 UTC) #2
Igor Sheludko
https://codereview.chromium.org/171813015/diff/1/src/v8.cc File src/v8.cc (right): https://codereview.chromium.org/171813015/diff/1/src/v8.cc#newcode189 src/v8.cc:189: if (FLAG_random_seed == 0) { On 2014/02/24 10:10:01, Sven ...
6 years, 10 months ago (2014-02-24 11:11:53 UTC) #3
Igor Sheludko
6 years, 9 months ago (2014-03-04 12:42:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19647 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698