Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: sync/engine/syncer.cc

Issue 171813013: sync: Merge GU retry logic into normal GU (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/syncer.h ('k') | sync/sessions/data_type_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/syncer.cc
diff --git a/sync/engine/syncer.cc b/sync/engine/syncer.cc
index 240332c5a9448b76d1f7c7c4fc3629cf24aa30f2..c75251028ef20131a650a6c16cd4a5f2f2157013 100644
--- a/sync/engine/syncer.cc
+++ b/sync/engine/syncer.cc
@@ -70,7 +70,7 @@ bool Syncer::NormalSyncShare(ModelTypeSet request_types,
session,
&get_updates_processor,
kCreateMobileBookmarksFolder)) {
- return HandleCycleEnd(session, nudge_tracker.updates_source());
+ return HandleCycleEnd(session, nudge_tracker.GetLegacySource());
}
}
@@ -81,7 +81,7 @@ bool Syncer::NormalSyncShare(ModelTypeSet request_types,
BuildAndPostCommits(request_types, session, &commit_processor);
session->mutable_status_controller()->set_commit_result(commit_result);
- return HandleCycleEnd(session, nudge_tracker.updates_source());
+ return HandleCycleEnd(session, nudge_tracker.GetLegacySource());
}
bool Syncer::ConfigureSyncShare(
@@ -118,22 +118,6 @@ bool Syncer::PollSyncShare(ModelTypeSet request_types,
return HandleCycleEnd(session, sync_pb::GetUpdatesCallerInfo::PERIODIC);
}
-bool Syncer::RetrySyncShare(ModelTypeSet request_types,
- SyncSession* session) {
- VLOG(1) << "Retrying types " << ModelTypeSetToString(request_types);
- HandleCycleBegin(session);
- RetryGetUpdatesDelegate retry_delegate;
- GetUpdatesProcessor get_updates_processor(
- session->context()->model_type_registry()->update_handler_map(),
- retry_delegate);
- DownloadAndApplyUpdates(
- request_types,
- session,
- &get_updates_processor,
- kCreateMobileBookmarksFolder);
- return HandleCycleEnd(session, sync_pb::GetUpdatesCallerInfo::RETRY);
-}
-
bool Syncer::DownloadAndApplyUpdates(
ModelTypeSet request_types,
SyncSession* session,
« no previous file with comments | « sync/engine/syncer.h ('k') | sync/sessions/data_type_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698