Move ProfileKeyedAPI implementations to take BrowserContext in the constructor (part 1).

chrome/browser/chromeos/extensions/media_player_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_MEDIA_PLAYER_API_H_
 #define CHROME_BROWSER_CHROMEOS_EXTENSIONS_MEDIA_PLAYER_API_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/extensions/api/profile_keyed_api_factory.h"
 #include "extensions/browser/extension_function.h"
 
-class Profile;
+namespace content {
+class BrowserContext;
+}
 
 namespace extensions {
 class MediaPlayerEventRouter;
 
 class MediaPlayerAPI : public ProfileKeyedAPI {
  public:
-  explicit MediaPlayerAPI(Profile* profile);
+  explicit MediaPlayerAPI(content::BrowserContext* context);
   virtual ~MediaPlayerAPI();
 
   // Convenience method to get the MediaPlayerAPI for a profile.
-  static MediaPlayerAPI* Get(Profile* profile);
+  static MediaPlayerAPI* Get(content::BrowserContext* context);
 
   MediaPlayerEventRouter* media_player_event_router();
 
   // ProfileKeyedAPI implementation.
   static ProfileKeyedAPIFactory<MediaPlayerAPI>* GetFactoryInstance();
 
  private:
   friend class ProfileKeyedAPIFactory<MediaPlayerAPI>;
 
-  Profile* const profile_;
+  content::BrowserContext* const context_;

[James Cook, 2014/02/20 17:47:21]

nit: I like to call member variables |browser_context_| because just |context_|
seems too generic.  (Is it a window context? A graphics context? A browser
context?)

I use |context| for function parameters, since you can quickly see from the
function signature that |context| is a BrowserContext.

[Yoyo Zhou, 2014/02/20 22:44:54]

This was actually easy to fix with sed and git cl format.

 
   // ProfileKeyedAPI implementation.
   static const char* service_name() {
     return "MediaPlayerAPI";
   }
   static const bool kServiceRedirectedInIncognito = true;
   static const bool kServiceIsNULLWhileTesting = true;
 
   scoped_ptr<MediaPlayerEventRouter> media_player_event_router_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaPlayerAPI);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_CHROMEOS_EXTENSIONS_MEDIA_PLAYER_API_H_