Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 171813002: Remove pp_ifdef from grd files in several directories. (Closed)

Created:
6 years, 10 months ago by newt (away)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Remove pp_ifdef from grd files in several directories. Generated using: > git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g" BUG=343235 TBR=gdk@chromium.org TBR=weitaosu@chromium.org TBR=michaeln@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M device/bluetooth/bluetooth_strings.grd View 4 chunks +11 lines, -11 lines 0 comments Download
M remoting/resources/remoting_strings.grd View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/inspector_strings.grd View 6 chunks +13 lines, -13 lines 0 comments Download
M webkit/glue/webkit_strings.grd View 7 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
newt (away)
joi: PTAL, thanks!
6 years, 10 months ago (2014-02-19 01:28:33 UTC) #1
Jói
LGTM
6 years, 10 months ago (2014-02-19 13:56:15 UTC) #2
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 10 months ago (2014-02-19 17:04:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/171813002/1
6 years, 10 months ago (2014-02-19 17:06:17 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 21:40:23 UTC) #5
Message was sent while issue was closed.
Change committed as 252102

Powered by Google App Engine
This is Rietveld 408576698