Added errno (or GetLastError code) to crash dump when systemAllocPages fails.

Added errno (or GetLastError code) to crash dump when systemAllocPages fails.

To understand WTF::initializeWithoutV8 crashes, we need more information
about the crashes' reason. I guess, such crashes might occur because of
systemAllocPages (i.e. mmap or VirtualAlloc) failures.
So added errno (or GetLastError() code) to crash dumps when
systemAllocPages fails.

BUG=584628
Committed: https://crrev.com/3b1a0eabd9367582b35ffea641da1ee07baf4501
Cr-Commit-Position: refs/heads/master@{#377245}

[tasak, 2016-02-22 09:03:34]

Patchset #3 (id:40001) has been deleted

[tasak, 2016-02-22 10:17:55]

Patchset #3 (id:60001) has been deleted

[tasak, 2016-02-22 10:18:02]

Patchset #2 (id:20001) has been deleted

[tasak, 2016-02-22 10:18:11]

Patchset #1 (id:1) has been deleted

[tasak, 2016-02-23 03:45:26]

tasak@google.com changed reviewers:
+ tzik@chromium.org

[tasak, 2016-02-23 03:45:27]

Would you review this CL?

I'm afraid that I misunderstand base::debug::alias and so on.

[sof, 2016-02-23 07:27:25]

https://codereview.chromium.org/1718123002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Partitions.cpp (left):

https://codereview.chromium.org/1718123002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Partitions.cpp:191:
base::debug::Alias(&signature);
If Alias() makes its (aliased) local variable persisted in minidumps, then
perhaps it would make sense to add this use of Alias() one level up to
handleOutOfMemory() ?

[tzik, 2016-02-24 02:12:27]

lgtm

[tasak, 2016-02-24 03:53:32]

tasak@google.com changed reviewers:
+ haraken@chromium.org

[tasak, 2016-02-24 03:53:33]

Thank you, tzik and sof.

+haraken
Would you review this CL?

https://codereview.chromium.org/1718123002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Partitions.cpp (left):

https://codereview.chromium.org/1718123002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Partitions.cpp:191:
base::debug::Alias(&signature);
On 2016/02/23 07:27:25, sof wrote:
> If Alias() makes its (aliased) local variable persisted in minidumps, then
> perhaps it would make sense to add this use of Alias() one level up to
> handleOutOfMemory() ?

I see.
Done.

[sof, 2016-02-24 06:17:06]

On 2016/02/24 03:53:33, tasak wrote:
> Thank you, tzik and sof.
> 
> +haraken
> Would you review this CL?
> 

lgtm, but owner review needed (the wtf/OWNERS file has a number of inactive
entries, btw.)

[haraken, 2016-02-24 07:32:24]

LGTM

[tasak, 2016-02-24 07:46:33]

The CQ bit was checked by tasak@google.com

[tasak, 2016-02-24 07:46:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/1718123002/#ps100001
(title: "modify handleOutOfMemory")

[commit-bot: I haz the power, 2016-02-24 07:46:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1718123002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1718123002/100001

[commit-bot: I haz the power, 2016-02-24 09:05:24]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-02-24 09:06:51]

Description was changed from

==========
Added errno (or GetLastError code) to crash dump when systemAllocPages fails.

To understand WTF::initializeWithoutV8 crashes, we need more information
about the crashes' reason. I guess, such crashes might occur because of
systemAllocPages (i.e. mmap or VirtualAlloc) failures.
So added errno (or GetLastError() code) to crash dumps when
systemAllocPages fails.

BUG=584628
==========

to

==========
Added errno (or GetLastError code) to crash dump when systemAllocPages fails.

To understand WTF::initializeWithoutV8 crashes, we need more information
about the crashes' reason. I guess, such crashes might occur because of
systemAllocPages (i.e. mmap or VirtualAlloc) failures.
So added errno (or GetLastError() code) to crash dumps when
systemAllocPages fails.

BUG=584628

Committed: https://crrev.com/3b1a0eabd9367582b35ffea641da1ee07baf4501
Cr-Commit-Position: refs/heads/master@{#377245}
==========

[commit-bot: I haz the power, 2016-02-24 09:06:52]

Patchset 2 (id:??) landed as
https://crrev.com/3b1a0eabd9367582b35ffea641da1ee07baf4501
Cr-Commit-Position: refs/heads/master@{#377245}