Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1896)

Unified Diff: tools/gn/visual_studio_writer.h

Issue 1718093006: Limit the set of Visual Studio projects generated by GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix filter path correction Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/visual_studio_writer.h
diff --git a/tools/gn/visual_studio_writer.h b/tools/gn/visual_studio_writer.h
index 040922054a0e210c7164ab9ea9f343a5d247a071..3322d8167eaf04014ef6c5360db0a2795e8487df 100644
--- a/tools/gn/visual_studio_writer.h
+++ b/tools/gn/visual_studio_writer.h
@@ -28,10 +28,17 @@ class VisualStudioWriter {
Vs2015 // Visual Studio 2015
};
+ // Writes Visual Studio project and solution files. |sln_name| is the optional
+ // solution file name ("all" is used if not specified). |dir_filters| is
+ // optional semicolon-separated list of path prefixes used to limit the set of
+ // generated projects. Only targets whose directory paths start with one of
+ // specified prefixes will be included to the solution.
// On failure will populate |err| and will return false.
static bool RunAndWriteFiles(const BuildSettings* build_settings,
Builder* builder,
Version version,
+ const std::string& sln_name,
+ const std::string& dir_filters,
Err* err);
private:
@@ -73,8 +80,7 @@ class VisualStudioWriter {
using SolutionProjects = std::vector<SolutionProject*>;
using SolutionFolders = std::vector<SolutionEntry*>;
- explicit VisualStudioWriter(const BuildSettings* build_settings,
- Version version);
+ VisualStudioWriter(const BuildSettings* build_settings, Version version);
~VisualStudioWriter();
bool WriteProjectFiles(const Target* target, Err* err);
@@ -83,7 +89,7 @@ class VisualStudioWriter {
const Target* target,
Err* err);
void WriteFiltersFileContents(std::ostream& out, const Target* target);
- bool WriteSolutionFile(Err* err);
+ bool WriteSolutionFile(const std::string& sln_name, Err* err);
void WriteSolutionFileContents(std::ostream& out,
const base::FilePath& solution_dir_path);

Powered by Google App Engine
This is Rietveld 408576698