Allow constant multiply both ways.

Allow constant multiply both ways.

asm.js permits both:
int * constant
constant * int

It does not, however, allow intishes in multiplies.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=mjsunit/asm-wasm,test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/0dd24015fb5bb7293305d22ce3077aaf750b8c73
Cr-Commit-Position: refs/heads/master@{#34222}

[bradn, 2016-02-23 08:22:38]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[titzer, 2016-02-23 15:52:18]

lgtm

https://codereview.chromium.org/1718083004/diff/1/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1718083004/diff/1/src/typing-asm.cc#newcode1212
src/typing-asm.cc:1212: int right_intish = intish_;
probably want int32_t here?

https://codereview.chromium.org/1718083004/diff/1/src/typing-asm.cc#newcode1230
src/typing-asm.cc:1230: FAIL(expr, "multiply must be by an literal integer");
by "an integer literal" ?

[bradn, 2016-02-23 16:27:09]

https://codereview.chromium.org/1718083004/diff/1/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1718083004/diff/1/src/typing-asm.cc#newcode1212
src/typing-asm.cc:1212: int right_intish = intish_;
On 2016/02/23 15:52:18, titzer wrote:
> probably want int32_t here?

I suppose. Done.

https://codereview.chromium.org/1718083004/diff/1/src/typing-asm.cc#newcode1230
src/typing-asm.cc:1230: FAIL(expr, "multiply must be by an literal integer");
On 2016/02/23 15:52:18, titzer wrote:
> by "an integer literal" ?

Done.

[bradn, 2016-02-23 16:28:19]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-02-23 16:28:20]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1718083004/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-02-23 16:28:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1718083004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1718083004/20001

[commit-bot: I haz the power, 2016-02-23 16:44:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 16:45:00]

Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)

[bradn, 2016-02-23 18:06:06]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-02-23 18:06:06]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1718083004/#ps40001
(title: "fi")

[commit-bot: I haz the power, 2016-02-23 18:06:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1718083004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1718083004/40001

[commit-bot: I haz the power, 2016-02-23 19:03:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-23 19:05:01]

Description was changed from

==========
Allow constant multiply both ways.

asm.js permits both:
int * constant
constant * int

It does not, however, allow intishes in multiplies.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=mjsunit/asm-wasm,test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N
==========

to

==========
Allow constant multiply both ways.

asm.js permits both:
int * constant
constant * int

It does not, however, allow intishes in multiplies.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=mjsunit/asm-wasm,test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/0dd24015fb5bb7293305d22ce3077aaf750b8c73
Cr-Commit-Position: refs/heads/master@{#34222}
==========

[commit-bot: I haz the power, 2016-02-23 19:05:02]

Patchset 3 (id:??) landed as
https://crrev.com/0dd24015fb5bb7293305d22ce3077aaf750b8c73
Cr-Commit-Position: refs/heads/master@{#34222}