Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1718083003: package_from_installed: Put env in json file behind "env" key. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, brucedawson
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

package_from_installed: Put env in json file behind "env" key. Every time I write a json file, I end up wishing I put my toplevel items into non-toplevel items down the line when I want to add more stuff to the json file. Address this now, while no toolchain with this json file has been built yet. Follow-up to https://codereview.chromium.org/1706423002/ BUG=495204 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M win_toolchain/package_from_installed.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
4 years, 10 months ago (2016-02-22 18:43:32 UTC) #2
scottmg
lgtm
4 years, 10 months ago (2016-02-22 21:33:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718083003/1
4 years, 10 months ago (2016-02-22 21:34:38 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 21:36:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298908

Powered by Google App Engine
This is Rietveld 408576698