Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: components/BUILD.gn

Issue 1718073002: Remove the 'ios_use_webrtc' build flag hack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« BUILD.gn ('K') | « build_overrides/webrtc.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/BUILD.gn
diff --git a/components/BUILD.gn b/components/BUILD.gn
index 01252738d793e7a4840474f19ad1dfc7016e5967..35a147328ab75ad1ed76f29a95d04591a0807caf 100644
--- a/components/BUILD.gn
+++ b/components/BUILD.gn
@@ -4,7 +4,6 @@
import("//build/config/features.gni")
import("//build/config/ui.gni")
-import("//build_overrides/webrtc.gni")
import("//testing/test.gni")
import("//tools/grit/repack.gni")
@@ -77,7 +76,10 @@ test("components_unittests") {
]
if (is_ios) {
- deps += [ "//components/translate/ios/browser:unit_tests" ]
+ deps += [
+ "//components/signin/ios/browser:unit_tests",
+ "//components/translate/ios/browser:unit_tests",
+ ]
if (target_cpu != "arm") {
# TODO(GYP): iOS arm builds of libwebp don't work yet.
@@ -88,6 +90,9 @@ test("components_unittests") {
"//components/auto_login_parser:unit_tests",
"//components/autofill/content/browser:unit_tests",
"//components/autofill/content/renderer:unit_tests",
+ "//components/autofill/core/browser:unit_tests",
+ "//components/autofill/core/common:unit_tests",
+ "//components/browser_sync/browser:unit_tests",
"//components/bubble:unit_tests",
"//components/captive_portal:unit_tests",
"//components/certificate_transparency:unit_tests",
@@ -104,9 +109,15 @@ test("components_unittests") {
"//components/domain_reliability:unit_tests",
"//components/error_page/renderer:unit_tests",
"//components/favicon/content:unit_tests",
+ "//components/favicon/core:unit_tests",
+ "//components/favicon_base:unit_tests",
+ "//components/gcm_driver:unit_tests",
"//components/gcm_driver/crypto:unit_tests",
"//components/guest_view/browser:unit_tests",
"//components/history/content/browser:unit_tests",
+ "//components/history/core/browser:unit_tests",
+ "//components/history/core/common:unit_tests",
+ "//components/invalidation/impl:unit_tests",
"//components/json_schema:unit_tests",
"//components/keyed_service/content:unit_tests",
"//components/language_usage_metrics:unit_tests",
@@ -116,22 +127,29 @@ test("components_unittests") {
"//components/navigation_interception:unit_tests",
"//components/network_hints/renderer:unit_tests",
"//components/offline_pages:unit_tests",
+ "//components/omnibox/browser:unit_tests",
"//components/packed_ct_ev_whitelist:unit_tests",
"//components/page_load_metrics/browser:unit_tests",
"//components/page_load_metrics/renderer:unit_tests",
"//components/password_manager/content/browser:unit_tests",
+ "//components/password_manager/core/browser:unit_tests",
+ "//components/password_manager/core/common:unit_tests",
+ "//components/password_manager/sync/browser:unit_tests",
"//components/power:unit_tests",
"//components/precache/content:unit_tests",
"//components/precache/core:unit_tests",
"//components/query_parser:unit_tests",
+ "//components/rappor:unit_tests",
"//components/safe_browsing_db:unit_tests",
"//components/safe_json:unit_tests",
"//components/scheduler:unit_tests",
"//components/search:unit_tests",
"//components/search_engines:unit_tests",
"//components/search_provider_logos:unit_tests",
+ "//components/signin/core/browser:unit_tests",
"//components/ssl_config:unit_tests",
"//components/sync_bookmarks:unit_tests",
+ "//components/sync_driver:unit_tests",
"//components/sync_sessions:unit_tests",
"//components/test_runner:test_runner",
"//components/tracing:unit_tests",
@@ -217,32 +235,6 @@ test("components_unittests") {
]
}
- if (!is_ios || ios_use_webrtc) {
- deps += [
- "//components/autofill/core/browser:unit_tests",
- "//components/autofill/core/common:unit_tests",
- "//components/browser_sync/browser:unit_tests",
- "//components/favicon/core:unit_tests",
- "//components/favicon_base:unit_tests",
- "//components/gcm_driver:unit_tests",
- "//components/history/core/browser:unit_tests",
- "//components/history/core/common:unit_tests",
- "//components/invalidation/impl:unit_tests",
- "//components/omnibox/browser:unit_tests",
- "//components/password_manager/core/browser:unit_tests",
- "//components/password_manager/core/common:unit_tests",
- "//components/password_manager/sync/browser:unit_tests",
- "//components/rappor:unit_tests",
- "//components/search:unit_tests",
- "//components/signin/core/browser:unit_tests",
- "//components/sync_driver:unit_tests",
- ]
- }
-
- if (ios_use_webrtc) {
- deps += [ "//components/signin/ios/browser:unit_tests" ]
- }
-
if (toolkit_views) {
# TODO bug 522654 Enable this when the undefined symbol is fixed in
# web_modal such that this links.
« BUILD.gn ('K') | « build_overrides/webrtc.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698