Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: BUILD.gn

Issue 1718073002: Remove the 'ios_use_webrtc' build flag hack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/features.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
11 import("//build/config/features.gni") 11 import("//build/config/features.gni")
12 import("//build/config/sanitizers/sanitizers.gni") 12 import("//build/config/sanitizers/sanitizers.gni")
13 import("//build/config/ui.gni") 13 import("//build/config/ui.gni")
14 import("//build_overrides/v8.gni") 14 import("//build_overrides/v8.gni")
15 import("//build_overrides/webrtc.gni")
16 import("//media/media_options.gni") 15 import("//media/media_options.gni")
17 import("//third_party/openh264/openh264_args.gni") 16 import("//third_party/openh264/openh264_args.gni")
18 17
19 if (is_android) { 18 if (is_android) {
20 import("//build/config/android/config.gni") 19 import("//build/config/android/config.gni")
21 } 20 }
22 21
23 declare_args() { 22 declare_args() {
24 # A list of extra dependencies to add to the root target. This allows a 23 # A list of extra dependencies to add to the root target. This allows a
25 # checkout to add additional targets without explicitly changing any checked- 24 # checkout to add additional targets without explicitly changing any checked-
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 "//ui/touch_selection:ui_touch_selection_unittests", 197 "//ui/touch_selection:ui_touch_selection_unittests",
199 ] 198 ]
200 } else { 199 } else {
201 deps += [ 200 deps += [
202 "//ios/net:ios_net_unittests", 201 "//ios/net:ios_net_unittests",
203 "//ios/public/provider/web", 202 "//ios/public/provider/web",
204 "//ios/testing:ocmock_support_unittest", 203 "//ios/testing:ocmock_support_unittest",
205 "//ios/web:ios_web_unittests", 204 "//ios/web:ios_web_unittests",
206 "//ios/web/shell:ios_web_shell", 205 "//ios/web/shell:ios_web_shell",
207 ] 206 ]
208
209 if (ios_use_webrtc) {
210 deps += [
211 "//ios/chrome:ios_chrome_unittests",
kjellander_chromium 2016/02/22 04:23:40 Shouldn't these be added by default now then?
Dirk Pranke 2016/02/22 04:34:27 Ooo, good catch. I had thought that they might alr
kjellander_chromium 2016/02/22 05:26:51 Just to be clear: I didn't analyze if they were, b
212 "//ios/chrome/app",
213 "//ios/chrome/browser",
214 "//ios/chrome/common",
215 "//ios/public/provider/chrome/browser",
216 ]
217 }
218 } 207 }
219 208
220 deps += root_extra_deps 209 deps += root_extra_deps
221 210
222 if (enable_extensions) { 211 if (enable_extensions) {
223 deps += [ "//extensions/shell:app_shell_unittests" ] 212 deps += [ "//extensions/shell:app_shell_unittests" ]
224 } 213 }
225 214
226 if (enable_media_router) { 215 if (enable_media_router) {
227 deps += [ "//chrome/browser/media/router" ] 216 deps += [ "//chrome/browser/media/router" ]
(...skipping 642 matching lines...) Expand 10 before | Expand all | Expand 10 after
870 ] 859 ]
871 860
872 if (target_cpu == "x86") { 861 if (target_cpu == "x86") {
873 deps += [ "//chrome/tools/crash_service:crash_service_win64" ] 862 deps += [ "//chrome/tools/crash_service:crash_service_win64" ]
874 } 863 }
875 } else { 864 } else {
876 deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ] 865 deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
877 } 866 }
878 } 867 }
879 } 868 }
OLDNEW
« no previous file with comments | « no previous file | build/config/features.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698