Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: ui/views/cocoa/bridged_content_view.mm

Issue 1718043003: MacViews: Clip contents for non-rectangular windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add tests. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/cocoa/bridged_content_view.h ('k') | ui/views/cocoa/bridged_native_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/cocoa/bridged_content_view.mm
diff --git a/ui/views/cocoa/bridged_content_view.mm b/ui/views/cocoa/bridged_content_view.mm
index 6022a44723bf99d9873d04bd6dcbebdb7bc66697..65b2a6d9cba20648b9c5a3f3359fa4e30e9c5437 100644
--- a/ui/views/cocoa/bridged_content_view.mm
+++ b/ui/views/cocoa/bridged_content_view.mm
@@ -230,6 +230,10 @@ gfx::Rect GetFirstRectForRangeHelper(const ui::TextInputClient* client,
[self removeTrackingArea:cursorTrackingArea_.get()];
}
+- (NSBezierPath*)windowMask {
+ return windowMask_.get();
+}
+
- (void)processCapturedMouseEvent:(NSEvent*)theEvent {
if (!hostedView_)
return;
@@ -268,8 +272,6 @@ gfx::Rect GetFirstRectForRangeHelper(const ui::TextInputClient* client,
}
- (void)updateWindowMask {
- DCHECK(![self inLiveResize]);
- DCHECK(base::mac::IsOSMavericksOrEarlier());
DCHECK(hostedView_);
views::Widget* widget = hostedView_->GetWidget();
@@ -435,13 +437,11 @@ gfx::Rect GetFirstRectForRangeHelper(const ui::TextInputClient* client,
- (void)viewDidEndLiveResize {
[super viewDidEndLiveResize];
- // We prevent updating the window mask and clipping the border around the
- // view, during a live resize. Hence update the window mask and redraw the
- // view after resize has completed.
- if (base::mac::IsOSMavericksOrEarlier()) {
- [self updateWindowMask];
+ // During a live resize, we prevent clipping the border around the view, which
+ // is required to generate drop shadows on OSX 10.9. Hence redraw the view
+ // after resize has completed.
+ if (base::mac::IsOSMavericksOrEarlier())
[self setNeedsDisplay:YES];
- }
}
- (void)drawRect:(NSRect)dirtyRect {
@@ -464,8 +464,8 @@ gfx::Rect GetFirstRectForRangeHelper(const ui::TextInputClient* client,
// boundary with clearColor and tell Cococa to regenerate drop shadow. See
// crbug.com/543671.
if (windowMask_ && ![self inLiveResize] &&
- !IsRectInsidePath(dirtyRect, windowMask_)) {
- DCHECK(base::mac::IsOSMavericksOrEarlier());
+ !IsRectInsidePath(dirtyRect, windowMask_) &&
+ base::mac::IsOSMavericksOrEarlier()) {
gfx::ScopedNSGraphicsContextSaveGState state;
// The outer rectangular path corresponding to the window.
« no previous file with comments | « ui/views/cocoa/bridged_content_view.h ('k') | ui/views/cocoa/bridged_native_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698