ui/views/DEPS - Issue 1718043003: MacViews: Clip contents for non-rectangular windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/views/DEPS

Issue 1718043003: MacViews: Clip contents for non-rectangular windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+skia/ext",	2 "+skia/ext",

3 "+third_party/iaccessible2",	3 "+third_party/iaccessible2",

4 "+third_party/skia",	4 "+third_party/skia",

5 "+ui/accessibility",	5 "+ui/accessibility",

6 "+ui/aura",	6 "+ui/aura",

7 "+ui/base",	7 "+ui/base",

8 "+ui/compositor",	8 "+ui/compositor",

9 "+ui/display",	9 "+ui/display",

10 "+ui/events",	10 "+ui/events",

11 "+ui/gfx",	11 "+ui/gfx",

12 "+ui/gl/test/gl_surface_test_support.h", # To initialize GL for tests.	12 "+ui/gl/test/gl_surface_test_support.h", # To initialize GL for tests.

13 "+ui/native_theme",	13 "+ui/native_theme",

14 "+ui/ozone/public",	14 "+ui/ozone/public",

15 "+ui/resources/grit/ui_resources.h",	15 "+ui/resources/grit/ui_resources.h",

16 "+ui/strings/grit/ui_strings.h",	16 "+ui/strings/grit/ui_strings.h",

17 "+ui/touch_selection",	17 "+ui/touch_selection",

18 "+ui/wm/core",	18 "+ui/wm/core",

19 "+ui/wm/public",	19 "+ui/wm/public",

20	20

21 "-testing/gmock",	21 "-testing/gmock",

22 ]	22 ]

23	23

24 specific_include_rules = {	24 specific_include_rules = {

	25 "bridged_native_widget\.mm" : [

	26 "+third_party/google_toolbox_for_mac/src/AppKit"
	tapted 2016/02/25 08:07:21 I think we can put this in ui/views/cocoa/DEPS, ma I think we can put this in ui/views/cocoa/DEPS, making it include_rules = [ "+ui/accelerated_widget_mac", +third_party/google_toolbox_for_mac/src", ] And make sure all the builders are happy with this, including a component build... deps += [ "//third_party/google_toolbox_for_mac" ] should have to go into a BUILD.gn file somewhere. also a .gyp. But also it's ObjectiveC, which has runtime linking, so stuff can still compile without this but fail at compile time with an `unrecognized selector` error karandeepb 2016/03/04 03:01:55 Done. Show quoted text On 2016/02/25 08:07:21, tapted wrote: > I think we can put this in ui/views/cocoa/DEPS, making it > > include_rules = [ > "+ui/accelerated_widget_mac", > +third_party/google_toolbox_for_mac/src", > ] > > > And make sure all the builders are happy with this, including a component > build... > > deps += [ "//third_party/google_toolbox_for_mac" ] > > should have to go into a BUILD.gn file somewhere. also a .gyp. But also it's > ObjectiveC, which has runtime linking, so stuff can still compile without this > but fail at compile time with an `unrecognized selector` error Done.
	27 ],

25 "examples_browser_main_parts\.cc": [	28 "examples_browser_main_parts\.cc": [

26 "+ui/wm/test"	29 "+ui/wm/test"

27 ],	30 ],

28 "view_unittest\.cc": [	31 "view_unittest\.cc": [

29 "+cc/playback"	32 "+cc/playback"

30 ],	33 ],

31 }	34 }

OLD	NEW

« no previous file with comments | « no previous file | ui/views/cocoa/bridged_content_view.h » ('j') | ui/views/cocoa/bridged_content_view.mm » ('J')