MacViews: Clip contents for non-rectangular windows.

ui/views/cocoa/bridged_content_view.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_COCOA_BRIDGED_CONTENT_VIEW_H_
 #define UI_VIEWS_COCOA_BRIDGED_CONTENT_VIEW_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/strings/string16.h"
@@ skipping 30 matching lines @@
   // The last tooltip text, used to limit updates.
   base::string16 lastTooltipText_;
 
   // Whether to draw an almost-transparent background with rounded corners so
   // that OSX correctly blurs the background showing through.
   BOOL drawMenuBackgroundForBlur_;
 
   // Whether dragging on the view moves the window.
   BOOL mouseDownCanMoveWindow_;
 
-  // The cached window mask. Only used for non-rectangular windows on 10.9.
+  // The cached window mask. Only used for non-rectangular windows. Used to clip
+  // window boundary and generate drop shadow on OSX 10.9 and for clipping view
+  // contents in BridgedNativeWidget.
   base::scoped_nsobject<NSBezierPath> windowMask_;
 }
 
 @property(readonly, nonatomic) views::View* hostedView;
 @property(assign, nonatomic) ui::TextInputClient* textInputClient;
 @property(assign, nonatomic) BOOL drawMenuBackgroundForBlur;
 
 // Extends an atomic, readonly property on NSView to make it assignable.
 // This usually returns YES if the view is transparent. We want to control it
 // so that BridgedNativeWidget can dynamically enable dragging of the window.
 @property(assign) BOOL mouseDownCanMoveWindow;
 
 // Initialize the NSView -> views::View bridge. |viewToHost| must be non-NULL.
 - (id)initWithView:(views::View*)viewToHost;
 
 // Clear the hosted view. For example, if it is about to be destroyed.
 - (void)clearView;
 
 // Process a mouse event captured while the widget had global mouse capture.
 - (void)processCapturedMouseEvent:(NSEvent*)theEvent;
 
 // Mac's version of views::corewm::TooltipController::UpdateIfRequired().
 // Updates the tooltip on the ToolTipBaseView if the text needs to change.
 // |locationInContent| is the position from the top left of the window's
 // contentRect (also this NSView's frame), as given by a ui::LocatedEvent.
 - (void)updateTooltipIfRequiredAt:(const gfx::Point&)locationInContent;
 
-// Update windowMask_ depending on the current view bounds.
-- (void)updateWindowMask;
+// Called by the BridgedNativeWidget, when the window and hence the view bounds
+// change.
+- (void)onSizeChanged;

[tapted, 2016/02/24 05:05:03]

perhaps just expose updateWindowMask?

[karandeepb, 2016/02/25 03:31:06]

Done. Wasn't it better encapsulation though, since bridged content view managed
its own state.

[tapted, 2016/02/25 08:07:21]

I think what I didn't like was that an NSView shouldn't need to be told that its
size changed -- it should be able to get that from Cocoa APIs.

+
+// Returns |windowMask_|.
+- (NSBezierPath*)windowMask;

[tapted, 2016/02/24 05:05:03]

@property(readonly, nonatomic) NSBezierPath* windowMask;

[karandeepb, 2016/02/25 03:31:06]

Done.

 
 @end
 
 #endif  // UI_VIEWS_COCOA_BRIDGED_CONTENT_VIEW_H_