Issue 1718013002: In summaries, don't drop unsafe prefixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1718013002: In summaries, don't drop unsafe prefixes. (Closed)

Created:
4 years, 10 months ago by Paul Berry

Modified:
4 years, 10 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

In summaries, don't drop unsafe prefixes. Previous to this CL, all prefixes were dropped during resynthesis, causing constant ASTs like `x.length` to get resynthesized as simply `length`, which did not retain enough information for constant evaluation. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b33be7dce03755760f021c0d08309e4f97711da5

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -6 lines)			Patch
	M	pkg/analyzer/lib/src/summary/resynthesize.dart	View		1 chunk	+14 lines, -3 lines	0 comments	Download
	M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View		2 chunks	+27 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 10 months ago (2016-02-22 13:22:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b33be7dce03755760f021c0d08309e4f97711da5 (presubmit successful).