Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1717993002: [wasm] Fix bug in CallImport. (Closed)

Created:
4 years, 10 months ago by titzer
Modified:
4 years, 10 months ago
Reviewers:
bradnelson, binji
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix bug in CallImport. R=binji@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/4e316c38c52f3d6f2a0ae7480b17f33d2482281b Cr-Commit-Position: refs/heads/master@{#34181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/import-table.js View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 10 months ago (2016-02-21 09:18:06 UTC) #1
bradnelson
lgtm
4 years, 10 months ago (2016-02-22 00:45:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717993002/1
4 years, 10 months ago (2016-02-22 00:45:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 00:46:56 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 00:47:11 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4e316c38c52f3d6f2a0ae7480b17f33d2482281b
Cr-Commit-Position: refs/heads/master@{#34181}

Powered by Google App Engine
This is Rietveld 408576698