Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 171793002: Remove pp_ifdef from grd files in components/. (Closed)

Created:
6 years, 10 months ago by newt (away)
Modified:
6 years, 10 months ago
Reviewers:
Jói
CC:
chromium-reviews
Visibility:
Public.

Description

Remove pp_ifdef from grd files in components/. Generated using: > cd src/components > git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g" BUG=343235 R=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252149

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M components/component_strings.grd View 5 chunks +11 lines, -11 lines 0 comments Download
M components/policy_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
newt (away)
PTAL, thanks!
6 years, 10 months ago (2014-02-19 01:20:00 UTC) #1
Jói
LGTM On Wed, Feb 19, 2014 at 1:20 AM, <newt@chromium.org> wrote: > Reviewers: Jói, > ...
6 years, 10 months ago (2014-02-19 13:56:10 UTC) #2
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 10 months ago (2014-02-19 19:25:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/171793002/1
6 years, 10 months ago (2014-02-19 19:39:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/171793002/1
6 years, 10 months ago (2014-02-20 00:17:04 UTC) #5
newt (away)
6 years, 10 months ago (2014-02-20 01:54:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r252149 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698