Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: src/js/proxy.js

Issue 1717893002: Remove the Proxy enumerate trap (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/contexts.h ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/proxy.js
diff --git a/src/js/proxy.js b/src/js/proxy.js
index 842bac02525dfba5af65c4f753b4a9582ff74d00..a111c0942725a5e578b145c55ad456e32f31dff7 100644
--- a/src/js/proxy.js
+++ b/src/js/proxy.js
@@ -12,11 +12,6 @@
// Imports
//
var GlobalProxy = global.Proxy;
-var MakeTypeError;
-
-utils.Import(function(from) {
- MakeTypeError = from.MakeTypeError;
-});
//----------------------------------------------------------------------------
@@ -25,33 +20,6 @@ function ProxyCreateRevocable(target, handler) {
return {proxy: p, revoke: () => %JSProxyRevoke(p)};
}
-// -------------------------------------------------------------------
-// Proxy Builtins
-
-// Implements part of ES6 9.5.11 Proxy.[[Enumerate]]:
-// Call the trap, which should return an iterator, exhaust the iterator,
-// and return an array containing the values.
-function ProxyEnumerate(trap, handler, target) {
- // 7. Let trapResult be ? Call(trap, handler, «target»).
- var trap_result = %_Call(trap, handler, target);
- // 8. If Type(trapResult) is not Object, throw a TypeError exception.
- if (!IS_RECEIVER(trap_result)) {
- throw MakeTypeError(kProxyEnumerateNonObject);
- }
- // 9. Return trapResult.
- var result = [];
- for (var it = trap_result.next(); !it.done; it = trap_result.next()) {
- var key = it.value;
- // Not yet spec'ed as of 2015-11-25, but will be spec'ed soon:
- // If the iterator returns a non-string value, throw a TypeError.
- if (!IS_STRING(key)) {
- throw MakeTypeError(kProxyEnumerateNonString);
- }
- result.push(key);
- }
- return result;
-}
-
//-------------------------------------------------------------------
//Set up non-enumerable properties of the Proxy object.
@@ -59,11 +27,4 @@ utils.InstallFunctions(GlobalProxy, DONT_ENUM, [
"revocable", ProxyCreateRevocable
]);
-// -------------------------------------------------------------------
-// Exports
-
-%InstallToContext([
- "proxy_enumerate", ProxyEnumerate,
-]);
-
})
« no previous file with comments | « src/contexts.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698