Remove the Proxy enumerate trap

Remove the Proxy enumerate trap

In ES2016, the Proxy enumerate trap is removed. This patch changes
for-in iteration on Proxies to use the ownKeys trap. Due to the clean
organization of that code, the patch basically consists of deletions.

R=adamk
LOG=Y
BUG=v8:4768
Committed: https://crrev.com/579c01072d29cf87ad1d7cc09257c34b7925a96a
Cr-Commit-Position: refs/heads/master@{#34200}

[adamk, 2016-02-20 01:54:17]

lgtm

[Dan Ehrenberg, 2016-02-22 18:40:05]

littledan@chromium.org changed reviewers:
+ cbruni@chromium.org

[Dan Ehrenberg, 2016-02-22 19:11:49]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-02-22 19:11:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717893002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717893002/1

[Camillo Bruni, 2016-02-22 19:22:50]

lgtm

that was indeed easier than it would sound at first :).
Too bad they didn't decide on this before we implemented it :P

[Dan Ehrenberg, 2016-02-22 19:27:08]

On 2016/02/22 at 19:22:50, cbruni wrote:
> lgtm
> 
> that was indeed easier than it would sound at first :).
> Too bad they didn't decide on this before we implemented it :P

Well, I guess we still have the complexity of the ordering requirements for
Reflect.ownKeys, so not all is lost :/

[commit-bot: I haz the power, 2016-02-22 19:29:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 19:29:15]

Try jobs failed on following builders:
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/1731)
  v8_linux64_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Dan Ehrenberg, 2016-02-22 20:45:45]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-02-22 20:45:45]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org,
adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1717893002/#ps20001
(title: "Fix tests")

[commit-bot: I haz the power, 2016-02-22 20:45:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717893002/20001

[commit-bot: I haz the power, 2016-02-22 21:09:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-22 21:11:42]

Description was changed from

==========
Remove the Proxy enumerate trap

In ES2016, the Proxy enumerate trap is removed. This patch changes
for-in iteration on Proxies to use the ownKeys trap. Due to the clean
organization of that code, the patch basically consists of deletions.

R=adamk
LOG=Y
BUG=v8:4768
==========

to

==========
Remove the Proxy enumerate trap

In ES2016, the Proxy enumerate trap is removed. This patch changes
for-in iteration on Proxies to use the ownKeys trap. Due to the clean
organization of that code, the patch basically consists of deletions.

R=adamk
LOG=Y
BUG=v8:4768

Committed: https://crrev.com/579c01072d29cf87ad1d7cc09257c34b7925a96a
Cr-Commit-Position: refs/heads/master@{#34200}
==========

[commit-bot: I haz the power, 2016-02-22 21:11:42]

Patchset 2 (id:??) landed as
https://crrev.com/579c01072d29cf87ad1d7cc09257c34b7925a96a
Cr-Commit-Position: refs/heads/master@{#34200}

[Camillo Bruni, 2016-03-01 09:55:11]

On 2016/02/22 at 21:11:42, commit-bot wrote:
> Patchset 2 (id:??) landed as
https://crrev.com/579c01072d29cf87ad1d7cc09257c34b7925a96a
> Cr-Commit-Position: refs/heads/master@{#34200}

seems like we missed some cases again which I didn't spot earlier ;)

target = {a:true};
target.__proto__ = {b:true};
proxy = new Proxy(target, {});
// for-in should now see a and b.

[Dan Ehrenberg, 2016-03-01 16:33:31]

On 2016/03/01 at 09:55:11, cbruni wrote:
> On 2016/02/22 at 21:11:42, commit-bot wrote:
> > Patchset 2 (id:??) landed as
https://crrev.com/579c01072d29cf87ad1d7cc09257c34b7925a96a
> > Cr-Commit-Position: refs/heads/master@{#34200}
> 
> seems like we missed some cases again which I didn't spot earlier ;)
> 
> target = {a:true};
> target.__proto__ = {b:true};
> proxy = new Proxy(target, {});
> // for-in should now see a and b.

Oops, should've added a test here. Sorry about that.