|
|
Created:
4 years, 10 months ago by krasin Modified:
4 years, 10 months ago CC:
chromium-reviews, blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEventSourceParserTest: fix invalid cast in GC finalizer.
This is a follow up to https://codereview.chromium.org/1642563002/
BUG=588320
Committed: https://crrev.com/4c8da94602727332cb62cf9544af8bd53dac753f
Cr-Commit-Position: refs/heads/master@{#376640}
Patch Set 1 #
Messages
Total messages: 19 (7 generated)
krasin@chromium.org changed reviewers: + kinuko@chromium.org, krasin@chromium.org, yhirano@chromium.org
Hi Yutaka and Kinuko! Please, review this fix for an invalid cast issue. It should fix the CFI buildbot: https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux
lgtm Thank you very much!
The CQ bit was checked by krasin@chromium.org
On 2016/02/19 23:27:16, yhirano wrote: > lgtm > Thank you very much! Thank you for the instant review! :)
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717863002/1
Kinuko, can you please LGTM as well? It needs an OWNERS approval
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717863002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by kinuko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717863002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== EventSourceParserTest: fix invalid cast in GC finalizer. This is a follow up to https://codereview.chromium.org/1642563002/ BUG=588320 ========== to ========== EventSourceParserTest: fix invalid cast in GC finalizer. This is a follow up to https://codereview.chromium.org/1642563002/ BUG=588320 Committed: https://crrev.com/4c8da94602727332cb62cf9544af8bd53dac753f Cr-Commit-Position: refs/heads/master@{#376640} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4c8da94602727332cb62cf9544af8bd53dac753f Cr-Commit-Position: refs/heads/master@{#376640} |