Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1717863002: EventSourceParserTest: fix invalid cast in GC finalizer. (Closed)

Created:
4 years, 10 months ago by krasin
Modified:
4 years, 10 months ago
Reviewers:
kinuko, krasin1, yhirano
CC:
chromium-reviews, blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EventSourceParserTest: fix invalid cast in GC finalizer. This is a follow up to https://codereview.chromium.org/1642563002/ BUG=588320 Committed: https://crrev.com/4c8da94602727332cb62cf9544af8bd53dac753f Cr-Commit-Position: refs/heads/master@{#376640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/page/EventSourceParserTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
krasin1
Hi Yutaka and Kinuko! Please, review this fix for an invalid cast issue. It should ...
4 years, 10 months ago (2016-02-19 23:26:49 UTC) #2
yhirano
lgtm Thank you very much!
4 years, 10 months ago (2016-02-19 23:27:16 UTC) #3
krasin1
On 2016/02/19 23:27:16, yhirano wrote: > lgtm > Thank you very much! Thank you for ...
4 years, 10 months ago (2016-02-19 23:28:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717863002/1
4 years, 10 months ago (2016-02-19 23:34:19 UTC) #6
krasin1
Kinuko, can you please LGTM as well? It needs an OWNERS approval
4 years, 10 months ago (2016-02-19 23:49:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/148160)
4 years, 10 months ago (2016-02-19 23:54:34 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717863002/1
4 years, 10 months ago (2016-02-20 06:09:44 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-20 07:07:18 UTC) #13
kinuko
lgtm
4 years, 10 months ago (2016-02-20 07:54:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717863002/1
4 years, 10 months ago (2016-02-20 07:55:37 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-20 08:06:32 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-20 08:08:45 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c8da94602727332cb62cf9544af8bd53dac753f
Cr-Commit-Position: refs/heads/master@{#376640}

Powered by Google App Engine
This is Rietveld 408576698