rAc: partial revert of 251484 to show correct sections in views dialog.

rAc: partial revert of 251484 to show correct sections in views dialog.

R=estade@chromium.org
BUG=344693
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252067

[Evan Stade, 2014-02-19 01:19:06]

lgtm

[Dan Beam, 2014-02-19 01:25:03]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-02-19 01:25:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/171783003/1

[commit-bot: I haz the power, 2014-02-19 02:08:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 02:08:26]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Dan Beam, 2014-02-19 02:55:21]

whoops, +groby@ for chrome/browser/ui/cocoa

[groby-ooo-7-16, 2014-02-19 17:34:13]

LGTM as in "does what it says on the box"

Not sure what the difference between the isVisible and SectionIsActive on the
controller is, though. And if SectionIsActive wouldn't be enough.

[Dan Beam, 2014-02-19 17:47:01]

On 2014/02/19 17:34:13, groby wrote:
> LGTM as in "does what it says on the box"
> 
> Not sure what the difference between the isVisible and SectionIsActive on the
> controller is, though. And if SectionIsActive wouldn't be enough.

obviously it isn't enough as everything was broken with no change to that code.

the new method I've added asks the *view* whether a section is visible, whereas
the controller says whether it *should* be visible.

[Dan Beam, 2014-02-19 17:47:12]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-02-19 17:53:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/171783003/210001

[commit-bot: I haz the power, 2014-02-19 20:46:33]

Change committed as 252067