Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1618)

Issue 1717823002: Don't expose HTMLSlotElement if Shadow DOM V1 is not enabled. (Closed)

Created:
4 years, 10 months ago by rune
Modified:
4 years, 10 months ago
Reviewers:
hayato, kochi
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't expose HTMLSlotElement if Shadow DOM V1 is not enabled. Invoking toString on the element serialized to [object HTMLSlotElement] which is not correct until we ship. R=hayato@chromium.org,kochi@chromium.org BUG=531990 Committed: https://crrev.com/c8a26d2ff5e41ff3281546f9a56514d352281eb5 Cr-Commit-Position: refs/heads/master@{#376701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/html/HTMLTagNames.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
rune
ptal
4 years, 10 months ago (2016-02-19 22:33:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717823002/1
4 years, 10 months ago (2016-02-19 22:40:54 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-20 01:38:43 UTC) #5
kochi
lgtm
4 years, 10 months ago (2016-02-22 06:33:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717823002/1
4 years, 10 months ago (2016-02-22 06:35:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 07:51:50 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 07:53:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8a26d2ff5e41ff3281546f9a56514d352281eb5
Cr-Commit-Position: refs/heads/master@{#376701}

Powered by Google App Engine
This is Rietveld 408576698