partial fix for #25220, handles inference for list/map literals

partial fix for #25220, handles inference for list/map literals

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/0bf5456fcb09a5e7d4e0549b4a1255e79b7dcb42

[Jennifer Messerly, 2016-02-19 22:01:02]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Jennifer Messerly, 2016-02-19 22:07:13]

BTW, there's an open question here, should we take into account information from
both sources? Right now, it prefers downwards, and only looks at the elements if
we didn't have a context type.

Probably matters more for Map. For example, if our context gives us a useful key
type but not a value type or vice versa. 

This is different from the generic function change I sent earlier, which is a
bit smarter in taking into account downwards info, then combining it with
upwards info in a later step.

[Leaf, 2016-02-20 00:28:27]

lgtm.

https://codereview.chromium.org/1717803003/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):

https://codereview.chromium.org/1717803003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1590: // TODO(vsm): Use
leafp's matchType here?
Did this get duplicated?

[Jennifer Messerly, 2016-02-20 00:37:04]

Thanks!

https://codereview.chromium.org/1717803003/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):

https://codereview.chromium.org/1717803003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1590: // TODO(vsm): Use
leafp's matchType here?
On 2016/02/20 00:28:27, Leaf wrote:
> Did this get duplicated?

oops, done. yeah "sort members" did something strange to this comment, so I
moved it inside the method. Maybe forgot to delete old one, or "sort members"
itself caused the dupe.

[Jennifer Messerly, 2016-02-20 00:44:13]

Description was changed from

==========
partial fix for #25220, handles inference for list/map literals
==========

to

==========
partial fix for #25220, handles inference for list/map literals

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0bf5456fcb09a5e7d4e0549b4a1255e79b7dcb42
==========

[Jennifer Messerly, 2016-02-20 00:44:15]

Committed patchset #3 (id:40001) manually as
0bf5456fcb09a5e7d4e0549b4a1255e79b7dcb42 (presubmit successful).