Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1717803002: Add a SafepointMutexLocker class so that it is possible to have scopes inside the MutexLocker which… (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
srdjan, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a SafepointMutexLocker class so that it is possible to have scopes inside the MutexLocker which could potentially trigger safepoints. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/5322692506e0f1af4e5c83ea8ae994498342466a

Patch Set 1 #

Patch Set 2 : self-code-review #

Patch Set 3 : self-code-review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M runtime/vm/isolate.h View 2 chunks +2 lines, -0 lines 1 comment Download
M runtime/vm/isolate.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/lockers.h View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M runtime/vm/lockers.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
M runtime/vm/symbols.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
siva
4 years, 10 months ago (2016-02-19 21:22:52 UTC) #2
siva
4 years, 10 months ago (2016-02-19 21:25:00 UTC) #3
srdjan
lgtm https://codereview.chromium.org/1717803002/diff/40001/runtime/vm/isolate.h File runtime/vm/isolate.h (right): https://codereview.chromium.org/1717803002/diff/40001/runtime/vm/isolate.h#newcode783 runtime/vm/isolate.h:783: Mutex* symbols_mutex_; // Protects concurrent access to teh ...
4 years, 10 months ago (2016-02-19 21:38:05 UTC) #4
siva
4 years, 10 months ago (2016-02-19 22:22:32 UTC) #6
siva
4 years, 10 months ago (2016-02-20 00:03:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5322692506e0f1af4e5c83ea8ae994498342466a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698