Fix an issue that download filename from content disposition is not sanitized

chrome/browser/android/download/download_manager_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/download/download_manager_service.h"
 
 #include "base/android/jni_string.h"
 #include "base/message_loop/message_loop.h"
 #include "base/time/time.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/grit/generated_resources.h"
 #include "content/public/browser/android/download_controller_android.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/download_item.h"
 #include "jni/DownloadManagerService_jni.h"
+#include "ui/base/l10n/l10n_util.h"
 
 using base::android::JavaParamRef;
 using base::android::ConvertJavaStringToUTF8;
 using base::android::ConvertUTF8ToJavaString;
 
 namespace {
 // The retry interval when resuming/canceling a download. This is needed because
 // when the browser process is launched, we have to wait until the download
 // history get loaded before a download can be resumed/cancelled. However,
 // we don't want to retry after a long period of time as the same download Id
@@ skipping 13 matching lines @@
   DownloadManagerService* service =
       new DownloadManagerService(env, jobj, manager);
   return reinterpret_cast<intptr_t>(service);
 }
 
 DownloadManagerService::DownloadManagerService(
     JNIEnv* env,
     jobject obj,
     content::DownloadManager* manager)
     : java_ref_(env, obj), manager_(manager) {
+  content::DownloadControllerAndroid::Get()->SetDefaultDownloadFileName(
+      l10n_util::GetStringUTF8(IDS_DEFAULT_DOWNLOAD_FILENAME));

[asanka, 2016/02/24 20:04:44]

Why can't DownloadControllerAndroid do this on its own?

[qinmin, 2016/02/24 21:56:06]

2 reasons:
1. IDS_DEFAULT_DOWNLOAD_FILENAME is in chrome/, instead of content/
2. l10n_util is in ui/base, and content/ doesn't depend on that

DownloadManagerService are initialized at browser start up, so it can pass the
localized string from chrome/ to content/

[asanka, 2016/02/24 22:08:03]

Ah. I overlooked the fact that DownloadControllerAndroid is in //content.

   manager_->AddObserver(this);
 }
 
 DownloadManagerService::~DownloadManagerService() {
   if (manager_)
     manager_->RemoveObserver(this);
 }
 
 void DownloadManagerService::ResumeDownload(JNIEnv* env,
                                             jobject obj,
@@ skipping 85 matching lines @@
                                                 const std::string& fileName) {
   if (!java_ref_.is_null()) {
     JNIEnv* env = base::android::AttachCurrentThread();
     Java_DownloadManagerService_onResumptionFailed(
         env, java_ref_.obj(), download_id,
         ConvertUTF8ToJavaString(env, fileName).obj());
   }
   if (!resume_callback_for_testing_.is_null())
     resume_callback_for_testing_.Run(false);
 }