Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1717743004: Fix asserts found in SampleApp and update the tests with additional interesting numbers. (Closed)

Created:
4 years, 10 months ago by herb_g
Modified:
4 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix asserts found in SampleApp and update the tests with additional interesting numbers. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1717743004 Committed: https://skia.googlesource.com/skia/+/f5d4746ad73ef5eabc927d3d988bb9ee97c77921

Patch Set 1 #

Patch Set 2 : Remove include used for debug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M src/core/SkScaleToSides.h View 1 1 chunk +11 lines, -5 lines 0 comments Download
M tests/ScaleToSidesTest.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
herb_g
The scale to sides code asserted on the PathFuzzer in SampleApp.
4 years, 10 months ago (2016-02-19 21:23:38 UTC) #4
herb_g
Remove include used for debug.
4 years, 10 months ago (2016-02-19 21:40:43 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717743004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717743004/20001
4 years, 10 months ago (2016-02-19 21:41:35 UTC) #7
robertphillips
lgtm
4 years, 10 months ago (2016-02-19 21:51:44 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-19 22:33:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717743004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717743004/20001
4 years, 10 months ago (2016-02-20 00:53:33 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-20 00:54:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f5d4746ad73ef5eabc927d3d988bb9ee97c77921

Powered by Google App Engine
This is Rietveld 408576698