Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 1717703002: Use invalidation sets to invalidate slotted elements. (Closed)

Created:
4 years, 10 months ago by rune
Modified:
4 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use invalidation sets to invalidate slotted elements. Mark invalidation sets as invalidating slotted elements when the invalidation set features come from a ::slotted pseudo element. When we encounter a <slot> element during style invalidation, match the invalidation sets marked as invalidating slotted elements against the distributed nodes list for the <slot>. R=hayato@chromium.org,kochi@chromium.org,ericwilligers@chromium.org BUG=587746 Committed: https://crrev.com/1186e0ce9d24569a366cf6b6027e6edc3a551080 Cr-Commit-Position: refs/heads/master@{#376698}

Patch Set 1 #

Patch Set 2 : Fixed expected text #

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717703002/1
4 years, 10 months ago (2016-02-19 18:40:38 UTC) #2
rune
ptal
4 years, 10 months ago (2016-02-19 18:40:49 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/176530)
4 years, 10 months ago (2016-02-19 20:08:15 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717703002/20001
4 years, 10 months ago (2016-02-19 22:22:37 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-20 00:40:29 UTC) #9
Eric Willigers
lgtm
4 years, 10 months ago (2016-02-22 01:05:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717703002/20001
4 years, 10 months ago (2016-02-22 06:08:27 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-22 07:26:22 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 07:27:31 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1186e0ce9d24569a366cf6b6027e6edc3a551080
Cr-Commit-Position: refs/heads/master@{#376698}

Powered by Google App Engine
This is Rietveld 408576698