clang/scripts/package.py: return exit code 0, when nothing to do.

clang/scripts/package.py: return exit code 0, when nothing to do.

BUG=578306
Committed: https://crrev.com/1662c27dd51418c59689de5c1a6fb0564995bd35
Cr-Commit-Position: refs/heads/master@{#376550}

[krasin1, 2016-02-19 19:33:39]

krasin@chromium.org changed reviewers:
+ hans@chromium.org, krasin@chromium.org, thakis@chromium.org

[krasin1, 2016-02-19 19:33:40]

Hi Nico and Hans,

this is a tiny follow-up for the clang upload bot. When the binaries are already
on Google Cloud Storage, it makes sense to keep the green status, as there's
nothing wrong.

That could be important for people, which would accidentally choose the clang
upload trybot for their CLs. By returning 0 (and quickly) we never get on their
way.

This is actually a reason that I only discovered today. It would be a good one
for arguing about the quick check that we have now.

Anyway, please, take a look.

[krasin1, 2016-02-19 19:34:27]

Quick check right now (exit status 1):
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
Quick check with exit status 0:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

[krasin1, 2016-02-19 19:36:00]

I am also completely fine to abandon this change. It might very well be that you
would like to see a red status here for some reason which I don't currently see.

[Nico, 2016-02-19 20:16:48]

I can see arguments for both behaviors; probably hard to say which one is better
without trying. If you want to land this, lgtm, if you want to not land this
fine with me too. Up to you.

[krasin1, 2016-02-19 20:18:21]

On 2016/02/19 20:16:48, Nico (ooo Fri Feb 19) wrote:
> I can see arguments for both behaviors; probably hard to say which one is
better
> without trying. If you want to land this, lgtm, if you want to not land this
> fine with me too. Up to you.

Ack, thanks.

Hans, what do you think?

[hans, 2016-02-19 21:05:17]

I'm fine either way really.

[krasin1, 2016-02-19 21:46:18]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-02-19 21:48:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1717693002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1717693002/1

[commit-bot: I haz the power, 2016-02-19 22:22:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-19 22:23:50]

Description was changed from

==========
clang/scripts/package.py: return exit code 0, when nothing to do.

BUG=578306
==========

to

==========
clang/scripts/package.py: return exit code 0, when nothing to do.

BUG=578306

Committed: https://crrev.com/1662c27dd51418c59689de5c1a6fb0564995bd35
Cr-Commit-Position: refs/heads/master@{#376550}
==========

[commit-bot: I haz the power, 2016-02-19 22:23:51]

Patchset 1 (id:??) landed as
https://crrev.com/1662c27dd51418c59689de5c1a6fb0564995bd35
Cr-Commit-Position: refs/heads/master@{#376550}