Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 1717653002: Remove copies of ExportNamespaceBuilder and PublicNamespaceBuilder. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove copies of ExportNamespaceBuilder and PublicNamespaceBuilder. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d32b808fa8d256572dcab11a5bec9df3fc380a62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -161 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 4 chunks +4 lines, -145 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-19 17:03:40 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-19 17:08:03 UTC) #2
scheglov
4 years, 10 months ago (2016-02-19 17:08:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d32b808fa8d256572dcab11a5bec9df3fc380a62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698