Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 1717633002: [Interpreter] Fix generate-bytecode-expectations help message. (Closed)

Created:
4 years, 10 months ago by Stefano Sanfilippo
Modified:
4 years, 10 months ago
Reviewers:
oth, rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fix generate-bytecode-expectations help message. --pool-type=int and double have now been merged into number. BUG=v8:4280 LOG=N Committed: https://crrev.com/67f75e30da463299b6b29690370c22a8f388db59 Cr-Commit-Position: refs/heads/master@{#34164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/interpreter/generate-bytecode-expectations.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Stefano Sanfilippo
4 years, 10 months ago (2016-02-19 14:46:41 UTC) #2
rmcilroy
lgtm
4 years, 10 months ago (2016-02-19 15:51:46 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717633002/1
4 years, 10 months ago (2016-02-19 15:52:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717633002/1
4 years, 10 months ago (2016-02-19 15:53:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 16:14:11 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 16:14:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67f75e30da463299b6b29690370c22a8f388db59
Cr-Commit-Position: refs/heads/master@{#34164}

Powered by Google App Engine
This is Rietveld 408576698