chrome/browser/resources/print_preview/print_preview.js - Issue 171763004: Remove pp_ifdef from resource files in chrome/browser and chrome/renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 171763004: Remove pp_ifdef from resource files in chrome/browser and chrome/renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/content_settings.html ('K') | « chrome/browser/resources/print_preview/print_preview.css ('k') | chrome/renderer/resources/plugin_placeholders.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/print_preview.js

diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js

index 3f083e09eb0dc9e16bd7e3060bfb973dc1924c3f..9891870302e97db837e06060da366082c52a42cb 100644

--- a/chrome/browser/resources/print_preview/print_preview.js

+++ b/chrome/browser/resources/print_preview/print_preview.js

@@ -724,12 +724,12 @@ cr.define('print_preview', function() {

this.metrics_.incrementDestinationSearchBucket(

print_preview.Metrics.DestinationSearchBucket.CANCELED);

} else {

- // <if expr="pp_ifdef('toolkit_views')">

+ // <if expr="toolkit_views">

Nico 2014/02/19 01:08:43 wot? Why is this in a comment?

newt (away) 2014/02/19 01:43:15 It's a polyglot? The JS comment just confuses thin

Nico 2014/02/19 01:44:50 Thanks, this is much less confusing now imho.

// On the toolkit_views environment, ESC key is handled by C++-side

// instead of JS-side.

return;

// </if>

- // <if expr="not pp_ifdef('toolkit_views')">

+ // <if expr="not toolkit_views">

// Dummy comment to absorb previous line's comment symbol.

this.close_();

// </if>